Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Missing entries in .gitignore #289

Closed
adrijshikhar opened this issue Feb 21, 2020 · 2 comments · Fixed by #290
Closed

Missing entries in .gitignore #289

adrijshikhar opened this issue Feb 21, 2020 · 2 comments · Fixed by #290
Assignees

Comments

@adrijshikhar
Copy link
Contributor

adrijshikhar commented Feb 21, 2020

Describe the bug
.vsocde and .dist are two folders that are created by Visual Studio Code.
.vscode contains the local settings for that workspace.
.dist is created by C++ extension in vscode.
These are local changes made and hence should be present in .gitignore so that no one accidentally commits these files.

To Reproduce
Steps to reproduce the behavior:

  1. Open a terminal and go to the root of the repo
  2. Type code . and let vsocde open
  3. Go back to the terminal and type ls
  4. See the error, two new folders will be created if you use custom settings and C++ extension

Expected behavior
.vscode and .dist should be present in .gitignore

Screenshots
Screenshot_20200221_222352

Desktop (please complete the following information):

  • OS: Kubuntu 18.04
  • Browser: Chrome
  • Version 80 (Official Build) (64-bit)
@jolanglinais
Copy link
Member

I'm not sure I understand the purpose of this, I don't think the repository has an issue with a .vscode or .dist folder.

@adrijshikhar
Copy link
Contributor Author

.vscode contains a file named settings.json, which contains the local settings for the vscode in that particular workspace. So if anyone accidentally commits this, and some other guy pulls his changes and his vscode will create its own settings.json which will increase the number of line changes and might break some of the custom changes that this user has applied to his vscode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants