Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

No visual indication of clause template search bar highlighting #269

Closed
Michael-Grover opened this issue Jan 29, 2020 · 10 comments · Fixed by #292
Closed

No visual indication of clause template search bar highlighting #269

Michael-Grover opened this issue Jan 29, 2020 · 10 comments · Fixed by #292
Assignees
Labels

Comments

@Michael-Grover
Copy link
Collaborator

Michael-Grover commented Jan 29, 2020

If I type text in the clause template search bar and then attempt to highlight the text, there is no visual indication that the text is highlighted, however I know the text is highlighted because if I press backspace, highlighted text will be deleted. I just can't see what's highlighted.

image

https://www.loom.com/share/75b31df8d96043d5911b844fdf2bb1ca

@Michael-Grover Michael-Grover added Type: Bug 🐛 Something isn't working A11Y 🔓 Accessibility related labels Jan 29, 2020
@adrijshikhar
Copy link
Contributor

i would like to work on this issue

@Michael-Grover
Copy link
Collaborator Author

Hi @adrijshikhar , I've assigned you to the issue, thank you! Let me or @irmerk know if you have any questions. I will add more detail to the description of this issue

@Michael-Grover
Copy link
Collaborator Author

@adrijshikhar I added more detail and a video to the issue description

@adrijshikhar
Copy link
Contributor

adrijshikhar commented Feb 22, 2020

I have set up the repo cicero-ui but it does not look like what it is in the video. Am I missing something?

Edit - template-studio-v2 uses cicero-ui for its components. So in order to fix assigned issue, i have to set up template-studio-v2 also, right?

@Michael-Grover
Copy link
Collaborator Author

Michael-Grover commented Feb 22, 2020

I'm not sure, @irmerk or @DianaLease may be able to help with this on Monday.

Until then I recommend checking out this information @jeromesimeon posted in the Accord Project Slack if you are interested in participating in Google Summer of Code with the Accord Project

For everyone who just joined: Welcome! Here are several useful pointers:
Google Summer of Code “How it Works” (including the timeline) https://summerofcode.withgoogle.com/how-it-works/
Google Summer of Code “Student Guide” https://google.github.io/gsocguides/student/
Accord Project organization page in GSoC https://summerofcode.withgoogle.com/organizations/5605109054046208/
Accord Project documentation https://docs.accordproject.org
Project ideas list https://github.com/accordproject/techdocs/wiki/Google-Summer-of-Code
We are looking forward to your project proposals! Feel free to suggest ideas for projects that are not on the list.

@adrijshikhar
Copy link
Contributor

Thanks.

@ankushbhardwxj
Copy link

@adrijshikhar I faced the same problem when I had set up this repo.

Edit - template-studio-v2 uses cicero-ui for its components. So in order to fix assigned issue, i have to set up template-studio-v2 also, right?

Could you help me set this up ?

@jolanglinais
Copy link
Member

@adrijshikhar @ankingcodes the README should likely be updated to better explain this, but the demo that runs locally by default in the repository is only the ContractEditor, not the TemplateLibrary component.

template-studio-v2 is the project which uses all these components at the moment. So local development of components other than ContractEditor will either take template-studio-v2 or tinkering with the demo code.

@ankushbhardwxj
Copy link

ankushbhardwxj commented Feb 23, 2020

tinkering with the demo code

@irmerk this turned out to be a safer route for me.

development of components other than ContractEditor will either take template-studio-v2

i did clone the template-studio-v2 repo and set it up , but the README there also was unclear about how npm link works (how components created here can be seen and tested there) . I'd be glad if either the README is updated or if you could explain how that works here.

@adrijshikhar
Copy link
Contributor

@adrijshikhar @ankingcodes the README should likely be updated to better explain this, but the demo that runs locally by default in the repository is only the ContractEditor, not the TemplateLibrary component.

template-studio-v2 is the project which uses all these components at the moment. So local development of components other than ContractEditor will either take template-studio-v2 or tinkering with the demo code.

I linked the development version of cicero-ui with template-studio-v2 and made the changes. I am not able to get your point, can you please elaborate it a bit? Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants