Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

VariablePlugin README #146

Closed
jolanglinais opened this issue Sep 27, 2019 · 9 comments
Closed

VariablePlugin README #146

jolanglinais opened this issue Sep 27, 2019 · 9 comments
Assignees
Labels
Difficulty: Starter Good First Issue (Taken) Hacktoberfest by DigitalOcean and DEV Type: Documentation 📝 Information and guides for clarification

Comments

@jolanglinais
Copy link
Member

VariablePlugin

This should have developer documentation associated with it to showcase how it can be used and its purpose.

VariablePlugin: A custom Slate plugin for using editable, highlighted variables within a clause

@jolanglinais jolanglinais added Good First Issue :octocat: Good for newcomers Difficulty: Starter Type: Documentation 📝 Information and guides for clarification Hacktoberfest by DigitalOcean and DEV labels Sep 27, 2019
@tingaloo
Copy link

tingaloo commented Oct 1, 2019

I'll give this one a shot!

@tingaloo
Copy link

tingaloo commented Oct 2, 2019

I am trying to run the demo app on the master branch, but i get these error messages.

webpack:///./node_mo…olbar/index.js?:104 Uncaught TypeError: Cannot read property 'div' of undefined
    at eval (webpack:///./node_mo…olbar/index.js?:104)
    at Object../node_modules/@accordproject/markdown-editor/dist/FormattingToolbar/index.js (bundle.js:583)
    at __webpack_require__ (bundle.js:20)
    at eval (webpack:///./node_mo…Editor/index.js?:26)
    at Object../node_modules/@accordproject/markdown-editor/dist/SlateAsInputEditor/index.js (bundle.js:666)
    at __webpack_require__ (bundle.js:20)
    at eval (webpack:///./node_mo…r/dist/index.js?:49)
    at Object../node_modules/@accordproject/markdown-editor/dist/index.js (bundle.js:810)
    at __webpack_require__ (bundle.js:20)
    at eval (webpack:///./demo/src/index.js?:11)

Is there a version that has a more stable demo app?

@jolanglinais
Copy link
Member Author

You'll want to develop cicero-ui within template-studio-v2 with these instructions: https://github.com/accordproject/cicero-ui#development

@jolanglinais
Copy link
Member Author

@tingaloo are you sure you're working off the latest version of master? The issue you're seeing was fixed in a markdown-editor release and a cicero-ui release

@tingaloo
Copy link

tingaloo commented Oct 2, 2019

@irmerk doh! you're right. i can work off of this now, thanks!

@jolanglinais
Copy link
Member Author

Opening this back up after 15 days stale.

@Innovator007
Copy link
Contributor

Can i work on this?

@Innovator007
Copy link
Contributor

Hi @irmerk can you review my pr here

@jolanglinais
Copy link
Member Author

Closed with #172

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Starter Good First Issue (Taken) Hacktoberfest by DigitalOcean and DEV Type: Documentation 📝 Information and guides for clarification
Projects
None yet
Development

No branches or pull requests

3 participants