Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plays to be scoped by album #245

Merged
merged 4 commits into from
Aug 22, 2021
Merged

Allow plays to be scoped by album #245

merged 4 commits into from
Aug 22, 2021

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Aug 21, 2021

Add a simple scope to get plays by the album they are related too

@robbevp robbevp added the enhancement New feature or request label Aug 21, 2021
@robbevp robbevp self-assigned this Aug 21, 2021
@robbevp robbevp mentioned this pull request Aug 21, 2021
Merged
@robbevp robbevp requested a review from chvp August 21, 2021 10:18
chvp
chvp requested changes Aug 21, 2021
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests.

@robbevp robbevp requested a review from chvp August 21, 2021 18:52
@chvp chvp enabled auto-merge (squash) August 22, 2021 08:37
@chvp chvp merged commit 478d7e5 into main Aug 22, 2021
@chvp chvp deleted the enhc/tracks-scope-by-album branch August 22, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

Assignees

@robbevp robbevp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbevp @chvp