Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to @include foundation-forms(); on fresh install #55

Open
rbrlortie opened this issue Feb 25, 2019 · 0 comments
Open

Unable to @include foundation-forms(); on fresh install #55

rbrlortie opened this issue Feb 25, 2019 · 0 comments

Comments

@rbrlortie
Copy link

On a fresh Nwayo install, I'm attempting to uncomment the following line // @include foundation-forms(); in \components\foundation\styles\_base.scss.

This outputs the following error:

Error in plugin "sass"
Message:
    nwayo/bower_components/foundation-sites/scss/forms/_text.scss
Error: Incompatible units em and rem.
  $height: ($input-font-size * unitless-calc($input-line-height)) + (get-side($input-padding, 'top') + get-side($input-padding, 'bottom')) - rem-calc(1);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 86:12  form-element()
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 127:5  foundation-form-text()
  nwayo/bower_components/foundation-sites/scss/forms/_forms.scss 26:3  foundation-forms()
  nwayo/components/foundation/styles/_base.scss 7:1                    @import
  nwayo/components/foundation/styles/foundation.scss 5:9               @import
  editor.undefined 7:9                                                 root stylesheet


🐒  Error in plugin "gulp-sass"
Message:
    nwayo/bower_components/foundation-sites/scss/forms/_text.scss
Error: Incompatible units em and rem.
  $height: ($input-font-size * unitless-calc($input-line-height)) + (get-side($input-padding, 'top') + get-side($input-padding, 'bottom')) - rem-calc(1);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 86:12  form-element()
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 127:5  foundation-form-text()
  nwayo/bower_components/foundation-sites/scss/forms/_forms.scss 26:3  foundation-forms()
  nwayo/components/foundation/styles/_base.scss 7:1                    @import
  nwayo/components/foundation/styles/foundation.scss 5:9               @import
  editor.undefined 7:9                                                 root stylesheet
Details:
    formatted: Error: Incompatible units em and rem.
  $height: ($input-font-size * unitless-calc($input-line-height)) + (get-side($input-padding, 'top') + get-side($input-padding, 'bottom')) - rem-calc(1);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 86:12  form-element()
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 127:5  foundation-form-text()
  nwayo/bower_components/foundation-sites/scss/forms/_forms.scss 26:3  foundation-forms()
  nwayo/components/foundation/styles/_base.scss 7:1                    @import
  nwayo/components/foundation/styles/foundation.scss 5:9               @import
  editor.undefined 7:9                                                 root stylesheet
    line: 86
    column: 12
    file: /mnt/c/xampp/htdocs/nwayotest/nwayo/bower_components/foundation-sites/scss/forms/_text.scss
    status: 1
    messageFormatted: nwayo/bower_components/foundation-sites/scss/forms/_text.scss
Error: Incompatible units em and rem.
  $height: ($input-font-size * unitless-calc($input-line-height)) + (get-side($input-padding, 'top') + get-side($input-padding, 'bottom')) - rem-calc(1);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 86:12  form-element()
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 127:5  foundation-form-text()
  nwayo/bower_components/foundation-sites/scss/forms/_forms.scss 26:3  foundation-forms()
  nwayo/components/foundation/styles/_base.scss 7:1                    @import
  nwayo/components/foundation/styles/foundation.scss 5:9               @import
  editor.undefined 7:9                                                 root stylesheet
    messageOriginal: Incompatible units em and rem.
  $height: ($input-font-size * unitless-calc($input-line-height)) + (get-side($input-padding, 'top') + get-side($input-padding, 'bottom')) - rem-calc(1);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 86:12  form-element()
  nwayo/bower_components/foundation-sites/scss/forms/_text.scss 127:5  foundation-form-text()
  nwayo/bower_components/foundation-sites/scss/forms/_forms.scss 26:3  foundation-forms()
  nwayo/components/foundation/styles/_base.scss 7:1                    @import
  nwayo/components/foundation/styles/foundation.scss 5:9               @import
  editor.undefined 7:9                                                 root stylesheet
    relativePath: nwayo/bower_components/foundation-sites/scss/forms/_text.scss

This is caused by the default values being em in \components\foundation\styles\config\_design.scss under the // 20. Forms section.

Changing those values to use the ones on https://foundation.zurb.com/sites/docs/forms.html#sass-reference fixes the problem (or simply commenting them and allowing Foundation to use it's default would also do the job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant