Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for using Absinthe with Apollo Client #722

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

schneidmaster
Copy link
Contributor

Hi there! I wrote a guide for using Absinthe with Apollo Client, replacing the existing stub. Let me know if you have feedback!

@benwilson512 benwilson512 requested a review from bruce May 1, 2019 18:24
@bruce
Copy link
Contributor

bruce commented May 1, 2019

Thanks, @schneidmaster! I'll read through, and I've asked for feedback from others in the #absinthe-graphql Slack channel that work with Apollo + Absinthe—hope to get this merged in very soon. We really appreciate documentation PRs!

@bruce bruce self-assigned this May 1, 2019
@schneidmaster
Copy link
Contributor Author

@bruce Let me know if you have any more feedback on this -- I made one addition based on a suggestion from bartek in the Slack channel 🙂

Copy link
Contributor

@bruce bruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great. I think in the future we may want to dig a bit more into, e.g., cookie vs JWT options, but this is a really solid start!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants