From c7f6f9e99a32ed773f34d62a8e696ef3f5097b2e Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 07:21:35 +1100 Subject: [PATCH 01/11] Add OpenSSL version warning * Add OpenSSL version warning --- src/main.d | 5 +++++ src/util.d | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) diff --git a/src/main.d b/src/main.d index 18c864efc..853500db3 100644 --- a/src/main.d +++ b/src/main.d @@ -231,6 +231,11 @@ int main(string[] cliArgs) { } } + // OpenSSL Version Check + // Example - on CentOS 7.9 (OpenSSL 1.0.2k-fips 26 Jan 2017), access with Microsoft OneDrive causes a segfault in sha1_block_data_order_avx from /lib64/libcrypto.so.10 + // See Discussion #2950 for gdb output + checkOpenSSLVersion(); + // In a debug scenario, to assist with understanding the run-time configuration, ensure this flag is set if (debugLogging) { appConfig.setValueBool("display_running_config", true); diff --git a/src/util.d b/src/util.d index 02cce5718..0545aa6bd 100644 --- a/src/util.d +++ b/src/util.d @@ -35,6 +35,7 @@ import core.sys.posix.unistd; import core.stdc.string; import core.sys.posix.signal; import etc.c.curl; +import std.process; // What other modules that we have created do we need to import? import log; @@ -1402,3 +1403,51 @@ bool isBadCurlVersion(string curlVersion) { // Check if the current version matches one of the supported versions return canFind(supportedVersions, curlVersion); } + +string getOpenSSLVersion() { + try { + // Execute 'openssl version' and capture the output + auto result = executeShell("openssl version"); + + // Strip any extraneous whitespace from the output + return result.output.strip(); + } catch (Exception e) { + // Handle any exceptions, possibly returning an error message + return "Error fetching OpenSSL version: " ~ e.msg; + } +} + +void checkOpenSSLVersion() { + // Get OpenSSL version string + auto versionString = getOpenSSLVersion(); + if (versionString.startsWith("Error")) { + addLogEntry(versionString); + exit(1); + } + + // Define regex to extract version parts + auto versionRegex = regex(r"OpenSSL\s(\d+)\.(\d+)\.(\d+)([a-z]?)"); + + auto matches = versionString.match(versionRegex); + if (matches.empty) { + addLogEntry("Unable to parse OpenSSL version."); + exit(1); + } + + // Extract major, minor, patch, and optional letter parts + uint major = matches.captures[1].to!uint; + uint minor = matches.captures[2].to!uint; + uint patch = matches.captures[3].to!uint; + string letter = matches.captures[4]; // Empty if version is 3.x.x or higher + + // Compare versions + if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || + (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { + addLogEntry("ERROR: Platform OpenSSL version is less than 1.1.1a. Exiting."); + exit(1); + } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { + addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues.", major, minor, patch, letter)); + } else if (major >= 3) { + // Do nothing for version >= 3.0.0 + } +} From cb157fa67a61b07711d9975dc44ed00318346289 Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 07:27:12 +1100 Subject: [PATCH 02/11] Update util.d * Use forceExit to allow logging to be done --- src/util.d | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util.d b/src/util.d index 0545aa6bd..19ad4b5f0 100644 --- a/src/util.d +++ b/src/util.d @@ -1422,7 +1422,8 @@ void checkOpenSSLVersion() { auto versionString = getOpenSSLVersion(); if (versionString.startsWith("Error")) { addLogEntry(versionString); - exit(1); + // Must force exit here, allow logging to be done + forceExit(); } // Define regex to extract version parts @@ -1431,7 +1432,8 @@ void checkOpenSSLVersion() { auto matches = versionString.match(versionRegex); if (matches.empty) { addLogEntry("Unable to parse OpenSSL version."); - exit(1); + // Must force exit here, allow logging to be done + forceExit(); } // Extract major, minor, patch, and optional letter parts @@ -1444,7 +1446,8 @@ void checkOpenSSLVersion() { if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { addLogEntry("ERROR: Platform OpenSSL version is less than 1.1.1a. Exiting."); - exit(1); + // Must force exit here, allow logging to be done + forceExit(); } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues.", major, minor, patch, letter)); } else if (major >= 3) { From 080d75b7298de8d1f2ea88c9b10c49dbb93a2e1e Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 07:47:04 +1100 Subject: [PATCH 03/11] Tweak PR * Tweak PR --- .github/actions/spelling/allow.txt | 2 ++ src/util.d | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/actions/spelling/allow.txt b/.github/actions/spelling/allow.txt index bb796b880..1072901a7 100644 --- a/.github/actions/spelling/allow.txt +++ b/.github/actions/spelling/allow.txt @@ -407,3 +407,5 @@ yourfile yourprogram Zorin zypper +avx +libcrypto \ No newline at end of file diff --git a/src/util.d b/src/util.d index 19ad4b5f0..423170072 100644 --- a/src/util.d +++ b/src/util.d @@ -734,7 +734,7 @@ void displayPosixErrorMessage(string message) { // Display the Error Message void displayGeneralErrorMessage(Exception e, string callingFunction=__FUNCTION__, int lineno=__LINE__) { addLogEntry(); // used rather than writeln - addLogEntry("ERROR: Encounter " ~ e.classinfo.name ~ ":"); + addLogEntry("ERROR: Encountered a " ~ e.classinfo.name ~ ":"); addLogEntry(" Error Message: " ~ e.msg); addLogEntry(" Calling Function: " ~ callingFunction); addLogEntry(" Line number: " ~ to!string(lineno)); @@ -1445,9 +1445,7 @@ void checkOpenSSLVersion() { // Compare versions if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { - addLogEntry("ERROR: Platform OpenSSL version is less than 1.1.1a. Exiting."); - // Must force exit here, allow logging to be done - forceExit(); + addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s is less than 1.1.1a and major operational issues are to be expected.", major, minor, patch, letter)); } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues.", major, minor, patch, letter)); } else if (major >= 3) { From d11e4c1d53f414efb867c99374df75167bdf17aa Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 15:35:58 +1100 Subject: [PATCH 04/11] Update allow.txt * ensure newline --- .github/actions/spelling/allow.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/spelling/allow.txt b/.github/actions/spelling/allow.txt index 1072901a7..5f351d87d 100644 --- a/.github/actions/spelling/allow.txt +++ b/.github/actions/spelling/allow.txt @@ -408,4 +408,4 @@ yourprogram Zorin zypper avx -libcrypto \ No newline at end of file +libcrypto From 77a185d7e55d2337ae5497da0ebae16ae4e9e4ab Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 15:46:47 +1100 Subject: [PATCH 05/11] Update util.d * update PR --- src/util.d | 83 +++++++++++++++++++++++++++++------------------------- 1 file changed, 45 insertions(+), 38 deletions(-) diff --git a/src/util.d b/src/util.d index 423170072..0245d5bc9 100644 --- a/src/util.d +++ b/src/util.d @@ -1405,50 +1405,57 @@ bool isBadCurlVersion(string curlVersion) { } string getOpenSSLVersion() { - try { - // Execute 'openssl version' and capture the output - auto result = executeShell("openssl version"); - - // Strip any extraneous whitespace from the output - return result.output.strip(); - } catch (Exception e) { - // Handle any exceptions, possibly returning an error message - return "Error fetching OpenSSL version: " ~ e.msg; - } + try { + // Execute 'openssl version' and capture the output + auto result = executeShell("openssl version"); + + // Strip any extraneous whitespace from the output + return result.output.strip(); + } catch (Exception e) { + // Handle any exceptions, possibly returning an error message + return "Error fetching OpenSSL version: " ~ e.msg; + } } void checkOpenSSLVersion() { - // Get OpenSSL version string - auto versionString = getOpenSSLVersion(); - if (versionString.startsWith("Error")) { - addLogEntry(versionString); - // Must force exit here, allow logging to be done + // Get OpenSSL version string + auto versionString = getOpenSSLVersion(); + if (versionString.startsWith("Error")) { + addLogEntry(versionString); + // Must force exit here, allow logging to be done forceExit(); - } + } - // Define regex to extract version parts - auto versionRegex = regex(r"OpenSSL\s(\d+)\.(\d+)\.(\d+)([a-z]?)"); + // Define regex to extract version parts + auto versionRegex = regex(r"OpenSSL\s(\d+)\.(\d+)\.(\d+)([a-z]?)"); - auto matches = versionString.match(versionRegex); - if (matches.empty) { - addLogEntry("Unable to parse OpenSSL version."); - // Must force exit here, allow logging to be done + auto matches = versionString.match(versionRegex); + if (matches.empty) { + addLogEntry("Unable to parse OpenSSL version."); + // Must force exit here, allow logging to be done forceExit(); - } + } - // Extract major, minor, patch, and optional letter parts - uint major = matches.captures[1].to!uint; - uint minor = matches.captures[2].to!uint; - uint patch = matches.captures[3].to!uint; - string letter = matches.captures[4]; // Empty if version is 3.x.x or higher - - // Compare versions - if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || - (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { - addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s is less than 1.1.1a and major operational issues are to be expected.", major, minor, patch, letter)); - } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { - addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues.", major, minor, patch, letter)); - } else if (major >= 3) { - // Do nothing for version >= 3.0.0 - } + // Extract major, minor, patch, and optional letter parts + uint major = matches.captures[1].to!uint; + uint minor = matches.captures[2].to!uint; + uint patch = matches.captures[3].to!uint; + string letter = matches.captures[4]; // Empty if version is 3.x.x or higher + string distributionWarning = " Please report this to your distribution and request that they provide a newer curl version for your platform or upgrade this yourself."; + + // Compare versions + if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || + (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { + addLogEntry(); + addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s is less than 1.1.1a. Major operational issues are to be expected.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(distributionWarning); + addLogEntry(); + } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { + addLogEntry(); + addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(distributionWarning); + addLogEntry(); + } else if (major >= 3) { + // Do nothing for version >= 3.0.0 + } } From 510b8d6aad5e437fb5eeaee312a1935bb32e0609 Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 15:49:18 +1100 Subject: [PATCH 06/11] Update util.d * Update warning message --- src/util.d | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util.d b/src/util.d index 0245d5bc9..75bca63d1 100644 --- a/src/util.d +++ b/src/util.d @@ -1441,7 +1441,7 @@ void checkOpenSSLVersion() { uint minor = matches.captures[2].to!uint; uint patch = matches.captures[3].to!uint; string letter = matches.captures[4]; // Empty if version is 3.x.x or higher - string distributionWarning = " Please report this to your distribution and request that they provide a newer curl version for your platform or upgrade this yourself."; + string distributionWarning = " Please report this to your distribution and request that they provide a newer OpenSSL version for your platform or upgrade this yourself."; // Compare versions if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || From fc244d45d33fc6e8f9ef4543bff6049afe4ebaae Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 16:00:01 +1100 Subject: [PATCH 07/11] update pr * update pr --- src/main.d | 9 +++++---- src/util.d | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/main.d b/src/main.d index 853500db3..a743673e9 100644 --- a/src/main.d +++ b/src/main.d @@ -203,14 +203,15 @@ int main(string[] cliArgs) { if (!appConfig.getValueBool("force_http_11")) { // get the curl version string curlVersion = getCurlVersionNumeric(); + string distributionWarning = " Please report this to your distribution and request that they provide a newer cURL version for your platform or upgrade this yourself."; // Is the version of curl or libcurl being used by the platform a known bad curl version for HTTP/2 support if (isBadCurlVersion(curlVersion)) { // add warning message - string curlWarningMessage = format("WARNING: Your curl/libcurl version (%s) has known HTTP/2 bugs that impact the use of this application.", curlVersion); + string curlWarningMessage = format("WARNING: Your cURL/libcurl version (%s) has known HTTP/2 bugs that impact the use of this application.", curlVersion); addLogEntry(); addLogEntry(curlWarningMessage, ["info", "notify"]); - addLogEntry(" Please report this to your distribution and request that they provide a newer curl version for your platform or upgrade this yourself."); + addLogEntry(distributionWarning); addLogEntry(" Downgrading all application operations to use HTTP/1.1 to ensure maximum operational stability."); addLogEntry(" Please read https://github.com/abraunegg/onedrive/blob/master/docs/usage.md#compatibility-with-curl for more information."); addLogEntry(); @@ -223,10 +224,10 @@ int main(string[] cliArgs) { // Is the version of curl or libcurl being used by the platform a known bad curl version if (isBadCurlVersion(curlVersion)) { // add warning message - string curlWarningMessage = format("WARNING: Your curl/libcurl version (%s) has known operational bugs that impact the use of this application.", curlVersion); + string curlWarningMessage = format("WARNING: Your cURL/libcurl version (%s) has known operational bugs that impact the use of this application.", curlVersion); addLogEntry(); addLogEntry(curlWarningMessage, ["info", "notify"]); - addLogEntry(" Please report this to your distribution and request that they provide a newer curl version for your platform or upgrade this yourself."); + addLogEntry(distributionWarning); addLogEntry(); } } diff --git a/src/util.d b/src/util.d index 75bca63d1..bc51c9d24 100644 --- a/src/util.d +++ b/src/util.d @@ -1447,12 +1447,12 @@ void checkOpenSSLVersion() { if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { addLogEntry(); - addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s is less than 1.1.1a. Major operational issues are to be expected.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s is less than 1.1.1a. Major operational issues are to be expected when using this client.", major, minor, patch, letter), ["info", "notify"]); addLogEntry(distributionWarning); addLogEntry(); } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { addLogEntry(); - addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues when using this client.", major, minor, patch, letter), ["info", "notify"]); addLogEntry(distributionWarning); addLogEntry(); } else if (major >= 3) { From 2eca91829e2318e58b9217e750001c79aa71e2e4 Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 16:05:52 +1100 Subject: [PATCH 08/11] Update main.d * update pr --- src/main.d | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main.d b/src/main.d index a743673e9..758d5e9fb 100644 --- a/src/main.d +++ b/src/main.d @@ -199,12 +199,14 @@ int main(string[] cliArgs) { } } + // Common warning + string distributionWarning = " Please report this to your distribution and request that they provide a newer cURL version for your platform or upgrade this yourself."; + // If 'force_http_11' = false, we need to check the curl version being used if (!appConfig.getValueBool("force_http_11")) { // get the curl version string curlVersion = getCurlVersionNumeric(); - string distributionWarning = " Please report this to your distribution and request that they provide a newer cURL version for your platform or upgrade this yourself."; - + // Is the version of curl or libcurl being used by the platform a known bad curl version for HTTP/2 support if (isBadCurlVersion(curlVersion)) { // add warning message From 55128c0024d1f3998a5306dcb4e32a549940e22b Mon Sep 17 00:00:00 2001 From: abraunegg Date: Tue, 12 Nov 2024 16:54:20 +1100 Subject: [PATCH 09/11] Update util.d * Make message consistent in output to cURL message --- src/util.d | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util.d b/src/util.d index bc51c9d24..3f39b2dc5 100644 --- a/src/util.d +++ b/src/util.d @@ -1447,12 +1447,12 @@ void checkOpenSSLVersion() { if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { addLogEntry(); - addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s is less than 1.1.1a. Major operational issues are to be expected when using this client.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(format("WARNING: Your OpenSSL version (%d.%d.%d%s) is less than 1.1.1a. Major operational issues are to be expected when using this client.", major, minor, patch, letter), ["info", "notify"]); addLogEntry(distributionWarning); addLogEntry(); } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { addLogEntry(); - addLogEntry(format("WARNING: Platform OpenSSL version %d.%d.%d%s may cause stability issues when using this client.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(format("WARNING: Your OpenSSL version (%d.%d.%d%s) may cause stability issues when using this client.", major, minor, patch, letter), ["info", "notify"]); addLogEntry(distributionWarning); addLogEntry(); } else if (major >= 3) { From ffee82ad6772a44ec6d973e7919ea0032cf94197 Mon Sep 17 00:00:00 2001 From: abraunegg Date: Wed, 13 Nov 2024 05:41:45 +1100 Subject: [PATCH 10/11] Update PR * Update PR --- src/main.d | 8 ++++---- src/util.d | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main.d b/src/main.d index 758d5e9fb..e26d9d1c3 100644 --- a/src/main.d +++ b/src/main.d @@ -200,7 +200,7 @@ int main(string[] cliArgs) { } // Common warning - string distributionWarning = " Please report this to your distribution and request that they provide a newer cURL version for your platform or upgrade this yourself."; + string distributionWarning = " Please report this to your distribution, requesting an update to a newer cURL version, or consider upgrading it yourself for optimal stability."; // If 'force_http_11' = false, we need to check the curl version being used if (!appConfig.getValueBool("force_http_11")) { @@ -210,11 +210,11 @@ int main(string[] cliArgs) { // Is the version of curl or libcurl being used by the platform a known bad curl version for HTTP/2 support if (isBadCurlVersion(curlVersion)) { // add warning message - string curlWarningMessage = format("WARNING: Your cURL/libcurl version (%s) has known HTTP/2 bugs that impact the use of this application.", curlVersion); + string curlWarningMessage = format("WARNING: Your cURL/libcurl version (%s) has known HTTP/2 bugs that impact the use of this client.", curlVersion); addLogEntry(); addLogEntry(curlWarningMessage, ["info", "notify"]); addLogEntry(distributionWarning); - addLogEntry(" Downgrading all application operations to use HTTP/1.1 to ensure maximum operational stability."); + addLogEntry(" Downgrading all client operations to use HTTP/1.1 to ensure maximum operational stability."); addLogEntry(" Please read https://github.com/abraunegg/onedrive/blob/master/docs/usage.md#compatibility-with-curl for more information."); addLogEntry(); appConfig.setValueBool("force_http_11" , true); @@ -226,7 +226,7 @@ int main(string[] cliArgs) { // Is the version of curl or libcurl being used by the platform a known bad curl version if (isBadCurlVersion(curlVersion)) { // add warning message - string curlWarningMessage = format("WARNING: Your cURL/libcurl version (%s) has known operational bugs that impact the use of this application.", curlVersion); + string curlWarningMessage = format("WARNING: Your cURL/libcurl version (%s) has known operational bugs that impact the use of this client.", curlVersion); addLogEntry(); addLogEntry(curlWarningMessage, ["info", "notify"]); addLogEntry(distributionWarning); diff --git a/src/util.d b/src/util.d index 3f39b2dc5..17b928d13 100644 --- a/src/util.d +++ b/src/util.d @@ -1441,18 +1441,18 @@ void checkOpenSSLVersion() { uint minor = matches.captures[2].to!uint; uint patch = matches.captures[3].to!uint; string letter = matches.captures[4]; // Empty if version is 3.x.x or higher - string distributionWarning = " Please report this to your distribution and request that they provide a newer OpenSSL version for your platform or upgrade this yourself."; + string distributionWarning = " Please report this to your distribution, requesting an update to a newer OpenSSL version, or consider upgrading it yourself for optimal stability."; // Compare versions if (major < 1 || (major == 1 && minor < 1) || (major == 1 && minor == 1 && patch < 1) || (major == 1 && minor == 1 && patch == 1 && (letter.empty || letter[0] < 'a'))) { addLogEntry(); - addLogEntry(format("WARNING: Your OpenSSL version (%d.%d.%d%s) is less than 1.1.1a. Major operational issues are to be expected when using this client.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(format("WARNING: Your OpenSSL version (%d.%d.%d%s) is below the minimum required version of 1.1.1a. Significant operational issues are likely when using this client.", major, minor, patch, letter), ["info", "notify"]); addLogEntry(distributionWarning); addLogEntry(); } else if (major == 1 && minor == 1 && patch == 1 && !letter.empty && letter[0] >= 'a' && letter[0] <= 'w') { addLogEntry(); - addLogEntry(format("WARNING: Your OpenSSL version (%d.%d.%d%s) may cause stability issues when using this client.", major, minor, patch, letter), ["info", "notify"]); + addLogEntry(format("WARNING: Your OpenSSL version (%d.%d.%d%s) may cause stability issues with this client.", major, minor, patch, letter), ["info", "notify"]); addLogEntry(distributionWarning); addLogEntry(); } else if (major >= 3) { From 2c7707ffec6d7eb09c565f7bd29ea8464d33e0e3 Mon Sep 17 00:00:00 2001 From: abraunegg Date: Wed, 13 Nov 2024 05:45:48 +1100 Subject: [PATCH 11/11] Update allow.txt * Sort allow words --- .github/actions/spelling/allow.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/spelling/allow.txt b/.github/actions/spelling/allow.txt index 5f351d87d..d5f6e4bff 100644 --- a/.github/actions/spelling/allow.txt +++ b/.github/actions/spelling/allow.txt @@ -31,6 +31,7 @@ autoclean autoprocess autoupdate avmkfdiitirnrenzljwc +avx baus bcdefghi bindir @@ -175,6 +176,7 @@ lgdk lgio lglib lgobject +libcrypto libdir libexec libexecdir @@ -407,5 +409,3 @@ yourfile yourprogram Zorin zypper -avx -libcrypto