Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable login #3054

Closed
Andrea-Bruno opened this issue Jan 1, 2025 · 13 comments
Closed

Bug: Unable login #3054

Andrea-Bruno opened this issue Jan 1, 2025 · 13 comments
Labels
Closed: Lack of Response Closed: Lack of Response from OP Local Environment Issue Cannot locally reproduce issue Not a bug

Comments

@Andrea-Bruno
Copy link

Andrea-Bruno commented Jan 1, 2025

Describe the bug

Login to Microsoft site does not return token, probably response_type value is wrong, or redirect page is wrong:
http request query:
response_type=code&prompt=login&redirect_uri=https://login.microsoftonline.com/common/oauth2/nativeclient

P.S.: I tried the old version 2.4 and the login operation returns the token correctly

Operating System Details

ubuntu desktop last version stable

Client Installation Method

From Source

OneDrive Account Type

Personal

What is your OneDrive Application Version

2.5.3

What is your OneDrive Application Configuration

I compiled it from the repository here on github (the latest release)

What is your 'curl' version

default

Where is your 'sync_dir' located

Local

What are all your system 'mount points'

default

What are all your local file system partition types

default

How do you use 'onedrive'

testing

Steps to reproduce the behaviour

try to login by link at the first startup

Complete Verbose Log Output

none

Screenshots

No response

Other Log Information or Details

No response

Additional context

No response

@Andrea-Bruno Andrea-Bruno added the Bug Something isn't working label Jan 1, 2025
@abraunegg
Copy link
Owner

@Andrea-Bruno
Please provide the following for both v2.4 and v2.5

@abraunegg
Copy link
Owner

@Andrea-Bruno
I am unable to reproduce this using v2.5.x using a Personal account type.

Your debug logs are required to investigate.

@Andrea-Bruno
Copy link
Author

Everything is as by default, first installation. The scenario is as follows: The first time the application is started from the terminal, it displays a URL to be pasted into the browser to authenticate and obtain the token. Once the authentication is done, the Microsoft site does not show the token (it shows a blank page), So it is not possible to proceed by entering the token from the terminal to complete the authentication.
Probably the response_type parameter you pass in the URL has the wrong value, instead of "code" it should be "token", but something else is wrong. In any case, the return page does not show the token to be copied and inserted into onedrive in the terminal. The official documentation follows:

https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow

response_type=code ???

@abraunegg
Copy link
Owner

Without doing a side by side URL code analysis (and I cant at the moment except for the brief check I have done + actual test of v2.4 and v2.5) - the Auth URL used in v2.4.x and v2.5.x is the same ...

So

Either this is an account issue or something else.

Please provide the debug logs as requested.

@abraunegg
Copy link
Owner

@Andrea-Bruno

Once the authentication is done, the Microsoft site does not show the token (it shows a blank page), So it is not possible to proceed by entering the token from the terminal to complete the authentication.

Please also read this link very carefully:

https://github.com/abraunegg/onedrive/blob/master/docs/usage.md#authorise-the-application-with-your-microsoft-onedrive-account

@abraunegg
Copy link
Owner

@Andrea-Bruno
Please can you respond with your debug logs from both versions.

@Andrea-Bruno
Copy link
Author

I don't think tath is a problem correlated with my account because with 2.4 I have get the authentication token, but with 2.5.x no!
I will tray to create a new Microsoft account and get the token with the new account.
In any case, the project is open source, and I will fix the problem with the authentication token.

@abraunegg
Copy link
Owner

@Andrea-Bruno
Can you please provide some screen shots and/or more evidence please. What I want to see is your actual web browser response and the URI generated when you say this is failing.

What you are saying is not aligning to how the client operates or how the client presents the URL to obtain the auth token.

In both versions - the auth url you are asked to open is the same (I am 99.9999% sure of this)

When you authenticate - the URI of the web browser is what you pass back into the application as the response that the application then uses to authenticate itself to Microsoft OneDrive.

This has not changed between v2.4 and v2.5

I cannot reproduce this issue you are claiming.

Using any OneDrive Personal Account - newly created today or one of my older ones - the authentication request with v2.5 works without issue and when the URI of the browser is passed back to the application, the client authenicates.

@abraunegg
Copy link
Owner

@Andrea-Bruno
Please can you provide debug logs and screen shot evidence of the issue you are facing

@abraunegg
Copy link
Owner

@Andrea-Bruno
Please can you provide evidence of the issue you are claiming.

@TheAwesome98-Real
Copy link

can repro, i think? the page returned is zero bytes long, on both librewolf and ungoogled-chromium. i'm using a business account

@TheAwesome98-Real
Copy link

TheAwesome98-Real commented Jan 7, 2025

never mind, user skill issue. you copy the url in

EDIT: also, i don't know how i managed to make this mistake. i've synced this account with this programme twice now

@abraunegg
Copy link
Owner

@TheAwesome98-Real
Easy mistake - but please read the documentation as this is detailed.

@Andrea-Bruno
I am closing this issue due to lack of response or evidence.

@abraunegg abraunegg added Closed: Lack of Response Closed: Lack of Response from OP Not a bug Local Environment Issue Cannot locally reproduce issue and removed Bug Something isn't working More Information Needed Waiting on Response Unable to reproduce labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed: Lack of Response Closed: Lack of Response from OP Local Environment Issue Cannot locally reproduce issue Not a bug
Projects
None yet
Development

No branches or pull requests

3 participants