Use parameterInfo.Name when modelNameProvider.Name is null. #4700

maliming · 2020-07-09T10:15:14Z

Use Case:
GetIdentitySecurityLogListInput has an property named Action. ASPNET CORE's RouteValueProvider will bind the current method name to this Action property, but this is not expected, I specified it to get the value from the querystring.

[HttpGet]
public Task<PagedResultDto<IdentitySecurityLogDto>> GetListAsync([FromQuery]GetIdentitySecurityLogListInput input)
{
	return IdentitySecurityLogAppService.GetListAsync(input);
}

volo.abp.identity.identitySecurityLog.getList = function(input, ajaxParams) {
  return abp.ajax($.extend(true, {
	url: abp.appPath + 'api/identity/security-logs' + abp.utils.buildQueryString([{ name: 'startTime', value: startTime }, { name: 'endTime', value: endTime }, { name: 'applicationName', value: applicationName }, { name: 'identity', value: identity }, { name: 'action', value: action }, { name: 'userName', value: userName }, { name: 'clientId', value: clientId }, { name: 'correlationId', value: correlationId }, { name: 'sorting', value: sorting }, { name: 'skipCount', value: skipCount }, { name: 'maxResultCount', value: maxResultCount }]) + '',
	type: 'GET'
  }, ajaxParams));
};

The generated proxy script is incorrect(should be input.xxx), we need to make it use the correct param name.

Use parameterInfo.Name when modelNameProvider.Name is null.

3199b5d

maliming added this to the 3.1 milestone Jul 9, 2020

maliming added the abp-framework label Jul 9, 2020

hikalkan merged commit 96c7ece into dev Jul 17, 2020

hikalkan deleted the maliming-patch-1 branch July 17, 2020 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use parameterInfo.Name when modelNameProvider.Name is null. #4700

Use parameterInfo.Name when modelNameProvider.Name is null. #4700

maliming commented Jul 9, 2020 •

edited

Loading

Use parameterInfo.Name when modelNameProvider.Name is null. #4700

Use parameterInfo.Name when modelNameProvider.Name is null. #4700

Conversation

maliming commented Jul 9, 2020 • edited Loading

maliming commented Jul 9, 2020 •

edited

Loading