Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateParserFormatter should be reviewed and a test double should provided at ThemeSharedTestingModule.withConfig if necessary #7290

Closed
armanozak opened this issue Jan 17, 2021 · 0 comments
Closed

DateParserFormatter should be reviewed and a test double should provided at ThemeSharedTestingModule.withConfig if necessary #7290

armanozak opened this issue Jan 17, 2021 · 0 comments
Assignees
@armanozak @mehmet-erim
Labels
effort-1 problem test ui-angular
Milestone
4.2-final

Comments

@armanozak
Copy link
Contributor

this.configState.getOne('localization') as ApplicationLocalizationConfigurationDto).currentCulture.dateTimeFormat fails in tests, because there is localization state.
@armanozak armanozak added this to the 4.2-final milestone Jan 17, 2021
@armanozak armanozak self-assigned this Jan 17, 2021
@armanozak armanozak changed the title A test double for DateParserFormatter should be provided at ThemeSharedTestingModule.withConfig DateParserFormatter should be reviewed and a test double should provided at ThemeSharedTestingModule.withConfig if necessary Jan 17, 2021
@armanozak armanozak mentioned this issue Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armanozak armanozak

@mehmet-erim mehmet-erim

Labels
effort-1 problem test ui-angular
Projects
None yet
Milestone
4.2-final
Development

No branches or pull requests
2 participants
@armanozak @mehmet-erim