Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining modules for repository queryable change #6964

Closed
3 tasks
hikalkan opened this issue Jan 2, 2021 · 1 comment · Fixed by #6985
Closed
3 tasks

Update remaining modules for repository queryable change #6964

hikalkan opened this issue Jan 2, 2021 · 1 comment · Fixed by #6985

Comments

@hikalkan
Copy link
Member

hikalkan commented Jan 2, 2021

For the #6809 I changed all the usages in this (abp) repository except the following modules:

  • blogging
  • docs
  • cms-kit

Please update all usages. Typically, you need to fix Obsolete warnings, but I suggest to check all the code touches to database. We normally don't use IRepository's IQueryable features, but we might be used implicitly in the repository.
The idea is not to write LINQ directly over the repository instance, but use GetQueryableAsync. Inside the repositories, I changed DbContext property to GetDbContextAsync() method, DbSet property to GetDbSetAsync() and so on. You can check the implementation of the Identity module as a reference.

I will merge #6809 today, then you can start ;)

@hikalkan
Copy link
Member Author

hikalkan commented Jan 2, 2021

I think you should merge it :) Please review it and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment