Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade HtmlAgilityPack package #5653

Closed
realLiangshiwei opened this issue Sep 30, 2020 · 2 comments · Fixed by #5654
Closed

Upgrade HtmlAgilityPack package #5653

realLiangshiwei opened this issue Sep 30, 2020 · 2 comments · Fixed by #5654
Assignees
@realLiangshiwei
Labels
abp-cli enhancement
Milestone
3.3-preview

Comments

@realLiangshiwei
Copy link
Member

HtmlAgilityPack.NetCore repository has been archived, we can use the latest HtmlAgilityPack.

By the way, We don’t seem to use any features of HtmlAgilityPack in Volo.Abp.Cli.Core, maybe we can remove the package reference.

abp/framework/src/Volo.Abp.Cli.Core/Volo.Abp.Cli.Core.csproj

Line 17 in 0efbf56

<PackageReference Include="HtmlAgilityPack.NetCore" Version="1.5.0.1" />

@realLiangshiwei realLiangshiwei self-assigned this Sep 30, 2020
@realLiangshiwei realLiangshiwei added this to the 3.3-preview milestone Sep 30, 2020
@realLiangshiwei realLiangshiwei mentioned this issue Sep 30, 2020
Merged
@hikalkan
Copy link
Member

If we don't use it anywhere, we can remove it. Otherwise, you can change it.

@NiceLisan
Copy link

yes, i aslo founded the package HtmlAgilityPack wan't used anywhere in the Volo.Abp.Cli.Core.csproj since the verision V3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realLiangshiwei realLiangshiwei

Labels
abp-cli enhancement
Projects
None yet
Milestone
3.3-preview
Development

Successfully merging a pull request may close this issue.

Remove the HtmlAgilityPack.NetCore reference from the ABP CLI abpframework/abp
3 participants
@hikalkan @realLiangshiwei @NiceLisan