Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call CompleteAsync instead of SaveChangesAsync #4689

Closed
realLiangshiwei opened this issue Jul 9, 2020 · 0 comments · Fixed by #4704
Closed

Call CompleteAsync instead of SaveChangesAsync #4689

realLiangshiwei opened this issue Jul 9, 2020 · 0 comments · Fixed by #4704
Assignees
@realLiangshiwei
Labels
abp-module-audit-logging abp-module-users enhancement
Milestone
3.1

Comments

@realLiangshiwei
Copy link
Member

abp/modules/audit-logging/src/Volo.Abp.AuditLogging.Domain/Volo/Abp/AuditLogging/AuditingStore.cs

Line 60 in a11914c

await uow.SaveChangesAsync();

abp/modules/users/src/Volo.Abp.Users.Domain/Volo/Abp/Users/UserLookupService.cs

Line 203 in 48cf71c

await uow.SaveChangesAsync();

Call CompleteAsync method is a better way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realLiangshiwei realLiangshiwei

Labels
abp-module-audit-logging abp-module-users enhancement
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

Use CompleteAsync instead of SaveChangesAsync abpframework/abp
1 participant
@realLiangshiwei