Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client_secret from the angular and ReactNative application. #4657

Closed
antosubash opened this issue Jul 7, 2020 · 2 comments
Closed
Assignees
Milestone

Comments

@antosubash
Copy link

There is definitely no good way to handle secrets on the client side. The client is not under your control and can never be trusted. This requires the change in the default implementation of the login in angular and ReactNative projects.

https://tools.ietf.org/html/draft-ietf-oauth-browser-based-apps-00#section-6.2

It will be great if Authorization Code Flow is used instead of client_credentials or password flow.

I think this will improve the security of client applications.

I'm still exploring the abp.io and loving it. Thanks for this amazing project.

@hikalkan hikalkan added this to the 3.2 milestone Jul 26, 2020
@hikalkan
Copy link
Member

We are using resource owner password flow. client has no permission itself. So, without a valid username/pass, the client name/secret does nothing.
However, we will be working on the other flows in the next versions.

@hikalkan
Copy link
Member

We changed to authorization code flow.. Account module will support both of authorization code and resource owner password flows. Authorization code will be default for new applications and we will create a simple guide to change for existing apps (very easy).

@hikalkan hikalkan modified the milestones: 3.2, 3.1 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants