Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major revision for module class/methods #3166

Closed
2 tasks done
hikalkan opened this issue Mar 17, 2020 · 1 comment · Fixed by #3184
Closed
2 tasks done

Major revision for module class/methods #3166

hikalkan opened this issue Mar 17, 2020 · 1 comment · Fixed by #3184
Assignees
@cotur
Labels
abp-module-account abp-module-audit-logging abp-module-background-jobs abp-module-feature-management abp-module-identity abp-module-identityserver abp-module-permission-management abp-module-setting-management abp-module-tenant-management effort-8 enhancement
Milestone
2.3

Comments

@hikalkan
Copy link
Member

hikalkan commented Mar 17, 2020 •
edited by cotur
Loading

For pre-built application modules;

  • Make all public/protected methods virtual (including entities, domain services, application services, page models, view components...) to make them easily overridable.
  • Make all private methods of domain & application services "propected virtual" to also be able to override them.
@hikalkan hikalkan added this to the 2.3 milestone Mar 17, 2020
@cotur
Copy link
Contributor

cotur commented Mar 18, 2020 •
edited
Loading

  • Account
  • Audit Logging
  • Background Jobs
  • Feature Management
  • Identity
  • Identity Server
  • Permission Management
  • Setting Management
  • Tenant Management

@cotur cotur mentioned this issue Mar 18, 2020
Merged
@cotur cotur removed the in-progress label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cotur cotur

Labels
abp-module-account abp-module-audit-logging abp-module-background-jobs abp-module-feature-management abp-module-identity abp-module-identityserver abp-module-permission-management abp-module-setting-management abp-module-tenant-management effort-8 enhancement
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Make TenantManagement module services easily overridable by inheritance abpframework/abp
2 participants
@hikalkan @cotur