Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSettings selector in the ConfigState should return empty object when the keyword is not found #3095

Closed
mehmet-erim opened this issue Mar 12, 2020 · 0 comments · Fixed by #3115
Closed

getSettings selector in the ConfigState should return empty object when the keyword is not found #3095

mehmet-erim opened this issue Mar 12, 2020 · 0 comments · Fixed by #3115
Assignees
@armanozak
Labels
breaking change bug effort-0.5 ui-angular
Milestone
2.3

Comments

@mehmet-erim
Copy link
Contributor

There is a bug in the getSettings selector logic. When the keyword is not found in the settings object of the ConfigState, the selector returns settings object. It should be returned empty object instead of settings object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armanozak armanozak

Labels
breaking change bug effort-0.5 ui-angular
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

fix: return empty object from getSettings when keyword is not found abpframework/abp
3 participants
@armanozak @cotur @mehmet-erim