Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build project if new version is released #19482

Closed
realLiangshiwei opened this issue Apr 3, 2024 · 3 comments
Closed

Can't build project if new version is released #19482

realLiangshiwei opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
abp-cli discussion effort-0 No need to set an effort
Milestone

Comments

@realLiangshiwei
Copy link
Member

https://support.abp.io/QA/Questions/6981/Can%27t-build-project-if-new-version-is-released

@EngincanV
Can we change the Leptonx theme version to the exact version number instead of a wildcard when creating a new project?
what do you think?

@enisn
Copy link
Member

enisn commented Apr 3, 2024

Yes, It makes sense for created projects. But check #19483
We have to update nightly (-preview) versions for each version deployed for development purposes.

Still, I agree that created ABP projects should have specific version that is created with.

Maybe we can use wildcard for development and CLI puts the specific version while project creation steps.

What do you think @EngincanV ?

@EngincanV
Copy link
Member

Yes, It makes sense for created projects. But check #19483 We have to update nightly (-preview) versions for each version deployed for development purposes.

Still, I agree that created ABP projects should have specific version that is created with.

Maybe we can use wildcard for development and CLI puts the specific version while project creation steps.

What do you think @EngincanV ?

I agree that we should specify the exact version of LeptonX Theme packages in abp template before every release. Doing this with CLI is easy but as we talked yesterday, this breaks the mentality of being able to release independent LeptonX releases and we would assume that the release schedule and cycle will be the same always. So, it occurs to me that the best option for now is to set the exact version for LeptonX Theme packages even before it's released (we should assume that it's released with the version that we specified).

@skoc10 skoc10 modified the milestones: 8.2-preview, 8.2-final Apr 25, 2024
@nebula2
Copy link
Contributor

nebula2 commented May 12, 2024

what if the cli would get the latest compatible leptonx version for the corresponding abp version (by hitting some api or something) on creation and then replaces on project creation?

@skoc10 skoc10 modified the milestones: 8.2-preview, 8.2-final May 20, 2024
@skoc10 skoc10 modified the milestones: 8.2-final, 8.2-patch Jun 27, 2024
@enisn enisn closed this as completed Jul 16, 2024
@enisn enisn added the effort-0 No need to set an effort label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abp-cli discussion effort-0 No need to set an effort
Projects
None yet
Development

No branches or pull requests

5 participants