Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingManager will do nothing if we call SetAsync with an undefined provider #18808

Closed
1 task done
PMExtra opened this issue Jan 19, 2024 · 0 comments · Fixed by #18823
Closed
1 task done

SettingManager will do nothing if we call SetAsync with an undefined provider #18808

PMExtra opened this issue Jan 19, 2024 · 0 comments · Fixed by #18823
Assignees
Milestone

Comments

@PMExtra
Copy link
Contributor

PMExtra commented Jan 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

SetAsync(string name, string value, string providerName, string providerKey, bool forceToSet = false):

When the providers list is empty, this call will do nothing and lose the setting value. Instead of throwing an exception which I expected.

Reproduction Steps

Call await SettingManager.SetAsync(key, value, "foo", null);

Expected behavior

Throw an exception to describe no providers named 'foo'.

Actual behavior

The method call finished successfully and did nothing.

Regression?

No response

Known Workarounds

No response

Version

7.4.5

User Interface

Common (Default)

Database Provider

EF Core (Default)

Tiered or separate authentication server

None (Default)

Operation System

Windows (Default)

Other information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants