Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu goes off screen and DataGrid has probably missing localization (_Adalvalmyndar_) for Icelandic #13992

Closed
sturlath opened this issue Sep 11, 2022 · 2 comments
Assignees
Milestone

Comments

@sturlath
Copy link
Contributor

sturlath commented Sep 11, 2022

When I browse to this menu on my phone the menu goes off screen

image

and then in DataGrid I get this _Adalvalmyndar_ (translates to _MainMenue_ in Icelandic) at the bottom

image

for complete sakes this is the code for the DataGrid

<Card>
    <CardHeader>
        <h2>@L["Events"]</h2>
    </CardHeader>
    <CardBody>
        <DataGrid TItem="BoughtEventDto"
                  Data="Entities"
                  ReadData="OnDataGridReadAsync"
                  Responsive="true"
                  Resizable="true"
                  TotalItems="TotalCount"
                  ShowPager="true"
                  PageSize="PageSize">
            <DataGridColumns>
                <DataGridColumn TItem="BoughtEventDto"
                                Field="@nameof(BoughtEventDto.EventName)"
                                Caption="@L["EventName"]"></DataGridColumn>
                <DataGridColumn TItem="BoughtEventDto"
                                Field="@nameof(BoughtEventDto.AmountPayed)"
                                Caption="@L["AmountPayed"]">

                </DataGridColumn>
                <DataGridColumn TItem="BoughtEventDto"
                                Field="@nameof(BoughtEventDto.StartingDate)"
                                Caption="@L["StartingDate"]">
                    <DisplayTemplate>
                        @context.StartingDate.ToShortDateString()
                    </DisplayTemplate>
                </DataGridColumn>
                <DataGridColumn TItem="BoughtEventDto"
                                Field="@nameof(BoughtEventDto.BoughtDate)"
                                Caption="@L["BoughtDate"]">
                    <DisplayTemplate>
                        @context.BoughtDate.ToLongDateString()
                    </DisplayTemplate>
                </DataGridColumn>
            </DataGridColumns>
        </DataGrid>
    </CardBody>
</Card>
  • Your ABP Framework version. 5.3.4
  • Your User Interface type MVC
@sturlath sturlath changed the title Menu goes off screen and s Menu goes off screen and DataGrid has probably missing localization (_Adalvalmyndar_) for Icelandic Sep 11, 2022
@sturlath
Copy link
Contributor Author

The localization is wrong for PagerShowMenuEntries and should have _MENU_ in it not _Adalvalmyndar_

So this line should be

"PagerShowMenuEntries": "Sýna færslur _MENU_",

@realLiangshiwei realLiangshiwei self-assigned this Sep 19, 2022
@realLiangshiwei
Copy link
Member

I will update the localization text, thanks @sturlath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants