REGISTER without FromUser will not be recognized as SIP paket

[thaeger71]

Hi,

I know, a REGISTER without FromUser doesn't make much sense, but to track down SIP issues it would be nice if such packet either be recognized as SIP paket, buit it doesn't.

Try to parse attached pcap which contains one register without FromUser.

Wireshark shows this paket too, without any problem ;-)

test.pcap.zip

[thaeger71]

I just saw that also the ToUser is not present in this REGISTER, maybe this is the reason that this packet will not be recognized as SIP packet ....

[jonbo372]

it is because any SIP URI is not allowed to have an empty user portion if there is a '@' sign present. Hence, this is an error: sip:@hello.com
but this is allowed: sip:hello.com

So it is not so much about REGISTER but rather that it fails to parse the SIP URI. I guess I could introduce a validate method instead that checks it and the framing is a little more relaxed.