Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a new and/or modified method to create/edit Conclusions #270

Closed
johnmhoran opened this issue Jul 21, 2018 · 3 comments
Closed

Consider a new and/or modified method to create/edit Conclusions #270

johnmhoran opened this issue Jul 21, 2018 · 3 comments
Assignees

Comments

@johnmhoran
Copy link
Member

The sole current method to create/edit a Conclusion is by right-clicking a node in the Treeview and selecting Edit Component (the naming convention is in transition -- this may become Edit Conclusion). When that option is selected, a modal window opens, which contains a form with editable elements (textboxes, radio button groups and dropdowns).

It could be useful to provide one or more additional methods to create/edit a Conclusion. One possible approach: modify the Component Summary View (which may be renamed Conclusions View) so that each row is editable in line.

This issue overlaps and should supersede issue #128.

@johnmhoran johnmhoran self-assigned this Jul 21, 2018
@steven-esser steven-esser added this to the v2.6.1 milestone Sep 24, 2018
@steven-esser steven-esser modified the milestones: v2.6.1, Future Dec 19, 2018
@steven-esser
Copy link
Contributor

Consolidations could possibly become conclusions automatically when a scan is loaded.

@johnmhoran
Copy link
Member Author

@MaJuRG I don't use ScanCode Workbench to create Conclusions so I don't know if this issue remains relevant, but I suspect the Conclusion process has changed since I opened this issue. I'm inclined to close this unless you think it should stay open.

@steven-esser
Copy link
Contributor

@johnmhoran good point, we have #242 and #390 which are more the direction we want to go with w.r.t. conclusions.

Doing them by hand will still be an option, but it will never be as practical as the above issues once completed.

@mjherzog mjherzog removed this from the Release v3.3.0 milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants