135 feat cross linking select heading depths #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about-code
added a commit
that referenced
this pull request
Dec 24, 2020
`indexing.headingDepths` affects term-based link creation as well as path resolution for existing links using heading ids to refer to a section in another document. `linking.headingDepths` is the option to actually control term-based link creation (effectively) based on previously indexed headings. This commit only adds `indexing.headingDepths`. `linking.headingDepths` was introduced in 95708c7 of PR #136.
about-code
added a commit
that referenced
this pull request
Dec 24, 2020
#139) `indexing.headingDepths` affects path resolution for cross-links using custom heading ids to refer to a section in another document *but also provides indexing* for term-based link creation. There should be rare cases for changing its default value. `linking.headingDepths` in contrast is the option to actually control term-based auto link creation *based on indexed headings*. `indexing.headingDepths` by default covers the complete set of CommonMark heading depths, that is, `[1,2,3,4,5,6]`. `linking.headingDepths` depends on headings being indexed and therefore must always be a complete _subset_ of `indexing.headingDepths`. If headings at, e.g. depth 5 would not be indexed, then they could not be found for auto linking, so even though `linking.headingDepths` might included 5, they were not auto linked. This commit adds `indexing.headingDepths` and modifies `linking.headingDepths` which was introduced in 95708c7 of PR #136. * test: New baseline. * test: Test cases for 'indexing.headingDepth' * test: Moved files. * test: Reordered test-suite to run tests for basic functionality before tests which are likely to depend on those functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135