26 aliases with trailing comma cause infinite loop (#33)

* fix: Aliases with trailing comma cause infinite loop and out of memory failure (#26) Closes #26
about-code · Sep 26, 2019 · d5ddd5b · d5ddd5b
1 parent 369f73f
commit d5ddd5b
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 0 deletions.
diff --git a/lib/terminator.js b/lib/terminator.js
@@ -145,6 +145,7 @@ function getTermVisitor(context, glossary) {
                         .replace(/\s?\S?--\>/gs, "")
                         .replace(/\b(.*)\b/gs, "$1")
                         .split(/\s?,\s?/)
+                        .filter(alias => alias !== "")
                 );
             }
             State.next(State.AWAIT_DEFINITION);

diff --git a/test/input/features/aliases_and_synonyms/glossary.md b/test/input/features/aliases_and_synonyms/glossary.md
@@ -33,3 +33,10 @@ T4.Alias3
 WHEN there is an HTML-multi-line-comment beginning with 'Aliases:' and an empty
 line THEN the subsequent comma-separated lines of words MUST be detected as the
 term's aliases.
+
+## Term 5
+<!-- Aliases: T5-Alias1, T5-Alias2, -->
+GIVEN there is an HTML-single-line-comment beginning with 'Aliases:'
+AND the comment ends with a trailing comma
+THEN this MUST NOT result in an infinite loop or out-of-memory error
+as has been reported in #26
diff --git a/test/output-expected/features/aliases_and_synonyms/glossary.md b/test/output-expected/features/aliases_and_synonyms/glossary.md
@@ -41,3 +41,12 @@ T4.Alias3
 WHEN there is an HTML-multi-line-comment beginning with 'Aliases:' and an empty
 line THEN the subsequent comma-separated lines of words MUST be detected as the
 term's aliases.
+
+## [Term 5](#term-5)
+
+<!-- Aliases: T5-Alias1, T5-Alias2, -->
+
+GIVEN there is an HTML-single-line-comment beginning with 'Aliases:'
+AND the comment ends with a trailing comma
+THEN this MUST NOT result in an infinite loop or out-of-memory error
+as has been reported in #26
diff --git a/test/output-expected/terms.json b/test/output-expected/terms.json
@@ -191,6 +191,25 @@
     ],
     "ignoreCase": false
   },
+  {
+    "shortDesc": "",
+    "term": "Term 5",
+    "hint": "",
+    "longDesc": "GIVEN there is an HTML-single-line-comment beginning with 'Aliases:'\nAND the comment ends with a trailing comma\nTHEN this MUST NOT result in an infinite loop or out-of-memory error\nas has been reported in #26",
+    "anchor": "#term-5",
+    "glossary": {
+      "file": "./features/aliases_and_synonyms/glossary.md",
+      "termHint": "",
+      "basePath": "/{redacted}/input/features/aliases_and_synonyms/glossary.md",
+      "outPath": "/{redacted}/output-actual/features/aliases_and_synonyms/glossary.md"
+    },
+    "regex": {},
+    "aliases": [
+      "T5-Alias1",
+      "T5-Alias2"
+    ],
+    "ignoreCase": false
+  },
   {
     "shortDesc": "",
     "term": "Term contains äöüß Umlauts",