RTN5 #98
Merged
RTN5 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _ in 1...max { | ||
| disposable.append(ARTRealtime(options: options)) | ||
|
|
||
| let channel = disposable.last?.channel(channelName) |
There was a problem hiding this comment.
instead of using last?, why not simply declare the client to make the code more readable such as:
let client = ARTRealtime(options: options)
disposable.append(client)
let channel = client.channel(channelName)
|
Nice, encouraging to see that work! 👍 |
ricardopereira
force-pushed
the
RTN5
branch
3 times, most recently
from
df1895b to
31e8d08
Compare
- Misplaced - Sometimes it was not reaching the number of messages. e.g. channel was not ready to receive the message
|
LGTM |
|
@mattheworiordan I think this was rebased, so I'm not sure if anything changed since your comment. Please merge if LGTY. |
|
LGTM |
mattheworiordan
added a commit
that referenced
this pull request
Jan 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.