Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rtl6d1 #802

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Add rtl6d1 #802

merged 3 commits into from
Sep 28, 2018

Conversation

funkyboy
Copy link
Contributor

Adds RTL6d1

(RTL6d) Messages for a single channel that have been queued may be sent in a single ProtocolMessage by bundling them into the ProtocolMessage#messages array, subject to the following constraints:
    (RTL6d1) The resulting ProtocolMesssage must not exceed the maxMessageSize

@funkyboy funkyboy changed the title Add rtl6d1 [WIP] Add rtl6d1 Sep 25, 2018
@funkyboy funkyboy changed the title [WIP] Add rtl6d1 Add rtl6d1 Sep 25, 2018
ricardopereira
ricardopereira suggested changes Sep 26, 2018
View reviewed changes
Spec/RealtimeClientChannel.swift
expect(protocolMessages.count).to(beGreaterThan(1))
// verify that all the messages have been sent
let messagesSent = protocolMessages.compactMap{$0.messages?.count}.reduce(0, +)
expect(messagesSent).to(equal(messagesToBeSent))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't detect where the resulting ProtocolMesssage is not exceeding the maxMessageSize. I think you should check if the messages are being blocked if the total size is exceeding the maxMessageSize, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had exactly the same thought at first :)
But this is queued messages, so the iOS client should bundle them in a way that the resulting protocol message does not exceed max size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see 😄 That's why the beGreaterThan(1).

paddybyers
paddybyers approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy funkyboy merged commit 428e029 into develop Sep 28, 2018
@funkyboy funkyboy deleted the add-RTL6d1 branch September 28, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardopereira ricardopereira ricardopereira approved these changes

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@funkyboy @paddybyers @ricardopereira