Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing instructions #704

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Update contributing instructions #704

merged 2 commits into from
Mar 23, 2018

Conversation

funkyboy
Copy link
Contributor

No description provided.

@paddybyers
Copy link
Member

I think you should add something to the Release process notes; at a minimum this needs to include (after pushing the tag):

fast-forward the master branch: git checkout master && git merge --ff-only develop

However, I do still think we need a common flow for all client library repos, and that it should include creating a separate branch for a release. We have to finalise the discussion that ended with https://github.com/ably/wiki/issues/262#issuecomment-363798120.

@funkyboy
Copy link
Contributor Author

@paddybyers better now?

paddybyers
paddybyers approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy funkyboy merged commit a96a2e3 into develop Mar 23, 2018
@funkyboy funkyboy deleted the update-readme branch March 23, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardopereira ricardopereira ricardopereira approved these changes

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@funkyboy @paddybyers @ricardopereira