Test suite #609
Merged
Test suite #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcard
reviewed
May 31, 2017
| @@ -530,6 +530,9 @@ BOOL ARTstartHandlingUncaughtExceptions(ARTRest *self) { | |||
| } | |||
|
|
|||
| void ARTstopHandlingUncaughtExceptions(ARTRest *self) { | |||
| if (!self) { | |||
There was a problem hiding this comment.
self should never be null here. When is it?
There was a problem hiding this comment.
@tcard Sorry, I can't recall when it was null but it wasn't in a normal state.
There was a problem hiding this comment.
@tcard Another thing. I was facing a deadlock as well. I spent some time at my lunch time to figure it out but the time wasn't enough. I will open a new PR.
|
I'm merging this since it'll improve stability, but I'd like to understand why this happens at some point. |
tcard
pushed a commit
that referenced
this pull request
May 31, 2017
* Update CocoaPods * Fix RSA8a: specific `_createTokenRequest` method * Fix ARTstopHandlingUncaughtExceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.