Log history #597
Merged
Log history #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcard
approved these changes
May 2, 2017
| return [self toString]; | ||
| } | ||
|
|
||
| #pragma mark - NSCoding |
There was a problem hiding this comment.
To save the object in disk with NSUserDefaults.
There was a problem hiding this comment.
If necessary. Currently, the logger does not store the history.
Source/ARTLog.m
Outdated
| } | ||
|
|
||
| - (instancetype)initCapturingOutput:(BOOL)capturing { | ||
| return [self initCapturingOutput:true historyLines:10]; |
There was a problem hiding this comment.
10 seems awfully low, should we bump to say 50 or 100?
There was a problem hiding this comment.
Done c3afa25.
ricardopereira
force-pushed
the
log-history
branch
from
15e8b7f to
71260ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #596.