Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TE6, TD7: Token{Request, Details}::fromJson #533

Merged
merged 2 commits into from
Nov 22, 2016
Merged

TE6, TD7: Token{Request, Details}::fromJson #533

merged 2 commits into from
Nov 22, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Nov 14, 2016

Implements ably/docs#193.

Fixes #529.

@mattheworiordan
Copy link
Member

@tcard unfortunately this needs to be fromJson instead of fromJSON. Can you amend please @tcard or @ricardopereira?

@ricardopereira
Copy link
Contributor

Ok, I'll do it.

@ricardopereira ricardopereira changed the title TE6, TD7: Token{Request, Details}::fromJSON TE6, TD7: Token{Request, Details}::fromJson Nov 17, 2016
@tcard tcard merged commit be1712a into master Nov 22, 2016
@tcard tcard deleted the 529-token-from-json branch November 22, 2016 19:21
@ricardopereira ricardopereira mentioned this pull request Nov 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcard @mattheworiordan @ricardopereira