RSA10g. #494
Merged
RSA10g. #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1582,6 +1582,7 @@ class Auth : QuickSpec { | |||
| authOptions.authParams?.append(NSURLQueryItem(name: "body", value: token)) | |||
| authOptions.authHeaders = ["X-Ably":"Test"] | |||
| authOptions.force = true | |||
| authOptions.queryTime = true | |||
There was a problem hiding this comment.
You've added queryTime in, yet there is no check to assert whether the time has been requested from Ably. We need to check this else I don't see the point of this.
There was a problem hiding this comment.
Got it, I'll add an assertion to be sure that time function has been called.
|
Please review and merge if everything looks good |
|
Will change the base to |
ricardopereira
force-pushed
the
RSA10g
branch
from
a554eb3 to
bd1c0b3
Compare
|
Squashed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.