Rtn2g #465
Rtn2g #465
Conversation
| done() | ||
| case .Connected: | ||
| if let transport = client.transport as? TestProxyTransport, let query = transport.lastUrl?.query { | ||
| expect(query).to(haveParam("lib", withValue: ARTDefault.libraryVersion())) |
There was a problem hiding this comment.
As mentioned in the REST test, I would be a lot happier know that the lib actually matches a string or regex we can read in the tests.
|
Thanks @EvgenyKarkan, looks good, only small comment re: test readability and predictability. Out of interest, why did you commit ed233af? |
|
Thanks for feedback @mattheworiordan |
|
Ok @EvgenyKarkan. This is probably exceptional because normally one PR (branch) can be based on another, but you need to be a collaborator in Github to do that. If we continue further, we'll of course make you a collaborator |
| done() | ||
| case .Connected: | ||
| if let transport = client.transport as? TestProxyTransport, let query = transport.lastUrl?.query { | ||
| expect(query).to(haveParam("lib", withValue: "ios-0.8.0-beta.1")) |
There was a problem hiding this comment.
Actually we're at 0.8.4 now. I didn't even know that there was such thing as a bundle version. Can you update it?
|
Hi @tcard , should I also update |
|
@EvgenyKarkan Yes, please. |
|
@tcard you happy for this to be merged? |
|
Yes, LGTM. |
* RSC7b * Minor cleanups. * The more verbose way to check header value. * Rtn2g (#465) * RSC7b * RTN2g * Minor cleanups. * Lib param expected value as explicitly string pattern. * Bump lib bundle version, minor fix to expect its value in test. * The more verbose way to check header value.
No description provided.