Rearrange types relationships to avoid ambiguities. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcard
force-pushed
the
rearrange-types
branch
3 times, most recently
from
7fefeb0 to
124c2be
Compare
|
Great 👌🏻 LGTM |
Previously, we had some situations in which, for convenience, we were inheriting rather than composing (RealtimeChannel inheriting from RestChannel). This was causing problems in places where some parent class implemented `method:(A)a` while a child class was implementing `method:(B)b`. Swift 2.2 doesn't let you do this, so it's necessary for that, but it's also a good idea for Swift <2.2 if only for code organization and soundness. Also added some changes in the test Swift code for forwards compatibility.
|
LGTM. Can you confirm this does not impact on our documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had some situations in which, for convenience, we were
inheriting rather than composing (RealtimeChannel inheriting from
RestChannel). This was causing problems in places where some parent
class implemented
method:(A)awhile a child class was implementingmethod:(B)b. Swift 2.2 doesn't let you do this, so it's necessary forthat, but it's also a good idea for Swift <2.2 if only for code
organization and soundness.
Also added some changes in the test Swift code for forwards
compatibility.