RTP6b #320
Merged
RTP6b #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| channel2.presence.enterClient("john", data: "online") | ||
| channel2.presence.updateClient("john", data: "away") | ||
| channel2.presence.leaveClient("john", data: nil) | ||
| done() |
There was a problem hiding this comment.
You are not waiting to check that the update event was received by the subscribe callback, this test could complete before that assertion.
There was a problem hiding this comment.
Agreed. Plus, you have to make sure that no other event is recorded. I suspect this won't work provided that #319 doesn't work, so I don't think this test would pass.
There was a problem hiding this comment.
Plus, you have to make sure that no other event is recorded.
@tcard Can you clarify, please.
There was a problem hiding this comment.
Nothing, actually, I somehow missed this line...
There was a problem hiding this comment.
Done dc09a31.
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.