Fix RTL1 #286
Merged
Fix RTL1 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me, but not sure about the error, will have to leave that to @tcard |
| @@ -70,11 +67,11 @@ class RealtimeClientChannel: QuickSpec { | |||
| } | |||
There was a problem hiding this comment.
I think line 49 above (can't comment on it) also needs a toEventually, or a wait until for the channel2.attach() callback.
There was a problem hiding this comment.
Also, the subscribe on line 52 should be moved above the channel2.attach(), to make sure it happens before it is attached.
There was a problem hiding this comment.
Done 60b1ef1. Thanks.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.