Fix RTN10b. #230
Merged
Fix RTN10b. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was checking the connection serial before the connection was established. The code behave correctly, but before CONNECTED serial was 0 just because it's the default int value, then set to -1 at CONNECTED. I've changed serial's initial value to -1, to make it not important whether you check it before of after the connection is established.
|
LGTM |
|
👍 |
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
spec: Fix listener issue in RTL7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was checking the connection serial before the connection
was established. The code behave correctly, but before CONNECTED
serial was 0 just because it's the default int value, then set to
-1 at CONNECTED. I've changed serial's initial value to -1, to
make it not important whether you check it before of after the
connection is established.