Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL10a #229

Merged
merged 4 commits into from
Feb 18, 2016
Merged

RTL10a #229

merged 4 commits into from
Feb 18, 2016

Conversation

ricardopereira
Copy link
Contributor

Review on Reviewable

@ricardopereira
Copy link
Contributor Author

Did 31db95f because of this strange conversion:

screen shot 2016-02-16 at 15 27 57

  • Changed historyWithError with just history.

@tcard
Copy link
Contributor

tcard commented Feb 17, 2016

I think a more definitive test would be to use Aspects to check that calling Realtime's history calls Rest's history. It's hard to completely test "Supports all the same params" otherwise; you would have to check what happens if you remove some, if they do the same, etc.

@ricardopereira
Copy link
Contributor Author

I think a more definitive test would be to use Aspects to check that calling Realtime's history calls Rest's history. It's hard to completely test "Supports all the same params" otherwise; you would have to check what happens if you remove some, if they do the same, etc.

@tcard Done

@tcard
Copy link
Contributor

tcard commented Feb 17, 2016

LGTM

@mattheworiordan
Copy link
Member

👍

ricardopereira added a commit that referenced this pull request Feb 18, 2016
@ricardopereira ricardopereira merged commit 597da03 into master Feb 18, 2016
@ricardopereira ricardopereira deleted the RTL10a branch February 18, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants