Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTL4a. #224

Merged
merged 2 commits into from
Feb 19, 2016
Merged

Fix RTL4a. #224

merged 2 commits into from
Feb 19, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Feb 16, 2016

Review on Reviewable

@ricardopereira
Copy link
Contributor

LGTM

mattheworiordan
mattheworiordan reviewed Feb 18, 2016
View reviewed changes
ably-ios/ARTRealtimeChannel.m
@@ -415,7 +415,7 @@ - (void)detach:(void (^)(ARTErrorInfo * _Nullable))cb {
case ARTRealtimeChannelDetaching:
case ARTRealtimeChannelDetached:
[self.realtime.logger debug:__FILE__ line:__LINE__ message:@"can't detach when not attahed"];
if (cb) cb([ARTErrorInfo createWithCode:90000 message:@"Can't detach when not attahed"]);
if (cb) cb(nil);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the typo in the already existing code on the line before, attached instead of attahed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done at 7836bbd.

@mattheworiordan
Copy link
Member

One minor request, but 👍

@tcard
Copy link
Contributor Author

tcard commented Feb 18, 2016

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

ably-ios/ARTRealtimeChannel.m, line 418 [r1] (raw file):
Done at 7836bbd.

Comments from the review on Reviewable.io

tcard added a commit that referenced this pull request Feb 19, 2016
@tcard
Merge pull request #224 from ably/fix-rtl4a
73b558b 
Fix RTL4a.
@tcard tcard merged commit 73b558b into master Feb 19, 2016
@tcard tcard deleted the fix-rtl4a branch February 19, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcard @ricardopereira @mattheworiordan