Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate BaseMessage private parts. #201

Merged
merged 2 commits into from
Feb 9, 2016
Merged

Separate BaseMessage private parts. #201

merged 2 commits into from
Feb 9, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Feb 8, 2016

Plus, remove useless content method.

@tcard
Copy link
Contributor Author

tcard commented Feb 8, 2016

Tests are failing because of #198 and #199. Will rebase this one once those are merged and should be passing then.

@tcard tcard force-pushed the basemessage-private branch from c44ae39 to 09ee6a5 Compare February 8, 2016 23:04
@ricardopereira
Copy link
Contributor

You need to add the ARTBaseMessage+Private.h to the private modulemap.

@ricardopereira
Copy link
Contributor

LGTM

1 similar comment
@mattheworiordan
Copy link
Member

LGTM

@tcard tcard force-pushed the basemessage-private branch from 09ee6a5 to e09104a Compare February 9, 2016 14:29
@tcard
Copy link
Contributor Author

tcard commented Feb 9, 2016

Rebased plus e09104a, what @ricardopereira said.

tcard added a commit that referenced this pull request Feb 9, 2016
@tcard
Merge pull request #201 from ably/basemessage-private
09055ff 
Separate BaseMessage private parts.
@tcard tcard merged commit 09055ff into master Feb 9, 2016
@tcard tcard deleted the basemessage-private branch February 9, 2016 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcard @ricardopereira @mattheworiordan