RTL4f #192
RTL4f #192
Conversation
|
LGTM |
| transport.actionsIgnored += [.Attached] | ||
|
|
||
| let channel = client.channel("test") | ||
| channel.attach() |
There was a problem hiding this comment.
To make this test more deterministic, I would prefer that you instanced the library with a lower realtimeRequestTimeout such as 3s, and then following attach, you should expect the state to change to failed in exactly 3s.
There was a problem hiding this comment.
@mattheworiordan realtimeRequestTimeout is currently readonly and I can't hack that method because it is a static method. The user should have access to change that option or not?
There was a problem hiding this comment.
See http://docs.ably.io/client-lib-development-guide/features/#DF1b, it's not a documented API, but we've made this configurable in our client libraries and left it undocumented for exactly this reason
|
Rebased with changes. |
|
LGTM, 👍 |
❌ Not passing.