Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings. #166

Merged
merged 1 commit into from
Jan 26, 2016
Merged

Fix compiler warnings. #166

merged 1 commit into from
Jan 26, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Jan 26, 2016

Mostly about using NSInteger in formatted strings, which the compiler dislikes.

Mostly about using NSInteger in formatted strings, which the compiler dislikes.
@mattheworiordan
Copy link
Member

Looks good, although Travis build stalled?

@tcard
Copy link
Contributor Author

tcard commented Jan 26, 2016

@mattheworiordan The CI build is broken right now (#143). It just stalls sometimes. We talked about this at the standup (I thought @ricardopereira said he would write it down). He has tried out this weekend Circe CI and something else and it still stalls there, so there must be something wrong with our build script or whatever. We agreed that fixing this is non-trivial and low priority right now, as we are only three people looking at PRs and we can just trust each other that the test suite passes in our machines for now. What do you think?

@mattheworiordan
Copy link
Member

It just stalls sometimes.

I do recall that discussion, however I understood we had a potential solution. I did not realise this issue was still present.

I agree it's not the highest priority, but it is an issue. Do we have an issue for it?

@ricardopereira
Copy link
Contributor

Yes, we have. The issue is #143.

@ricardopereira
Copy link
Contributor

LGTM

ricardopereira added a commit that referenced this pull request Jan 26, 2016
@ricardopereira ricardopereira merged commit b4b8b04 into master Jan 26, 2016
@ricardopereira ricardopereira deleted the fix-warnings branch January 27, 2016 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants