RTN12c

[ricardopereira]

Passing

[tcard]

I don't think this is a valid mock, because if the real transport does indeed close abruptly it won't make up a ProtocolMessage.CLOSE. I guess the connection should be notified of the close somehow (with a callback, I guess) and then check the current state, so that if it is CLOSING it transitions to CLOSED.

[mattheworiordan]

Agreed, this is completely the wrong behaviour. We want the transport on(closed) event equivalent to be triggered by the test suite so that the client library thinks the transport was abruptly terminated.

[ricardopereira]

Rebased with changes.

[ricardopereira]

DISCONNECTED (6)
Passed by the service to a client in response to a DISCONNECT message or if a connection has been disconnected because of an error state with the error reason included in the DISCONNECT Protocol Message.

https://github.com/ably/ably-ios/blob/b755c200717e81188651c8bdb19bf71f31b9d7d6/ably-ios/ARTWebSocketTransport.m#L251 I think the ARTWsAbnormalClose, ... should also call the delegate.realtimeTransportClosed instead of delegate.realtimeTransportDisconnected.

[mattheworiordan]

LGTM

[tcard]

LGTM

[ricardopereira]

It's important to merge #169 first, remove 435317c, rebase with master and check if it's ok.