Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually test RSA8c1. #149

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Actually test RSA8c1. #149

merged 1 commit into from
Jan 22, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Jan 20, 2016

The test was left incomplete. It didn't check the GET query nor
the headers.

@tcard
Copy link
Contributor Author

tcard commented Jan 20, 2016

Failing due to #143, can't break Obj-C tests, should be considered passing.

@mattheworiordan
Copy link
Member

LGTM 👍

@ricardopereira
Copy link
Contributor

LGTM

@ricardopereira
Copy link
Contributor

Please, do not merge. I want to test it on my machine.

The test was left incomplete. It didn't check the GET query nor
the headers.
tcard added a commit that referenced this pull request Jan 22, 2016
@tcard tcard merged commit f4765e1 into master Jan 22, 2016
@ricardopereira ricardopereira deleted the test-rsa8c1 branch January 27, 2016 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants