RTL4: Fix test that was doing nothing. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Doesn't compile: |
hasAttached was never being written. Also, now expectation is fullfilled when the channel is closed so that the no-op `[channel attach]` calls can have an observable effect if they're wrong, ie. if they transition again to ATTACHED.
|
Sorry, I forgot to run the Obj-C suite on my machine. PTAL |
|
Ok, bit of a messy test but it's legacy so looks good in that at least it's fixed |
|
Pretty much all the Obj-C tests are like this. Each of them is huge, and test several things. IMHO it's not worth fixing most of them, they should be superseded by proper unit tests in the Swift suite. |
tcard
added a commit
that referenced
this pull request
Jan 21, 2016
RTL4: Fix test that was doing nothing.
|
Agreed, not worth fixing, we have bigger fish to fry! |
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
Re-add RTN16d (accidentally removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasAttached was never being written. Also, now expectation is
fullfilled when the channel is closed so that the no-op
[channel attach]calls can have an observable effect if they'rewrong, ie. if they transition again to ATTACHED.