Don't use if-let to unwrap when it is sure that it will succeed. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to be failing due to what #139 is supposed to fix. |
|
👍 |
|
Now tests fail because of #142, but succeed in Swift otherwise. Obj-C suite isn't run, but can't be broken by this PR. So tests can be considered to be passing. |
Force-unwrap with `!` instead. Otherwise, if the if-let fails to unwrap the optional, it will be silently ignored. `!` crashes the program at least, so that we know that we have something wrong in the test code.
|
LGTM |
tcard
added a commit
that referenced
this pull request
Jan 20, 2016
Don't use if-let to unwrap when it is sure that it will succeed.
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
spec: add RTS5 - create a derived channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force-unwrap with
!instead. Otherwise, if the if-let fails tounwrap the optional, it will be silently ignored.
!crashes theprogram at least, so that we know that we have something wrong
in the test code.