Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address warnings in KSCrash fork #680

Closed
funkyboy opened this issue Jan 31, 2018 · 4 comments
Closed

Address warnings in KSCrash fork #680

funkyboy opened this issue Jan 31, 2018 · 4 comments
Labels
enhancement New feature or improved functionality.

Comments

@funkyboy
Copy link
Contributor

https://github.com/ably-forks/KSCrash
@funkyboy funkyboy added the enhancement New feature or improved functionality. label Jan 31, 2018
@funkyboy
Copy link
Contributor Author

funkyboy commented Feb 7, 2018 •
edited
Loading

Update: I tried merging changes from upstream.
I kept hitting compilation errors like this while running pod lib lint

Likely due to a change of folder structure in the upstream master branch

KSCrash> pod lib lint

 -> KSCrashAblyFork (1.15.8-ably-1)
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Tools/KSThread.h:74:23: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Tools/KSMachineContext.h:40:29: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Tools/KSMachineContext.h:44:28: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Tools/KSMachineContext.h:64:21: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Tools/KSLogger.h:262:24: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/KSCrashC.h:198:27: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/KSCrashC.h:229:30: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor.h:60:42: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor.h:76:22: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_AppState.h:99:24: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_AppState.h:128:40: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_System.h:40:38: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/KSCrashCachedData.h:34:18: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/KSCrashCachedData.h:35:20: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/KSCrashReportStore.h:55:25: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/KSCrashReportStore.h:86:28: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_Deadlock.h:53:40: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_User.h:68:36: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_Zombie.h:62:38: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_MachException.h:45:45: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_CPPException.h:37:44: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_NSException.h:45:43: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_Signal.h:45:38: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor.c:58:33: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Tools/KSDynamicLinker.h:55:20: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Reporting/Tools/KSReachabilityKSCrash.h:133:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Reporting/Tools/KSReachabilityKSCrash.h:149:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Reporting/Tools/KSReachabilityKSCrash.m:307:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Reporting/Tools/KSReachabilityKSCrash.m:314:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:198:27: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:229:30: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSThread.h:74:23: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:40:29: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:44:28: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:64:21: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSDynamicLinker.h:55:20: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSLogger.h:262:24: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:133:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-iphonesimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:149:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_System.m:502:72: warning: 'operatingSystemVersion' is only available on macOS 10.10 or newer [-Wunguarded-availability]
    - NOTE  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSProcessInfo.h:54:47: note: 'operatingSystemVersion' has been explicitly marked partial here
    - NOTE  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Recording/Monitors/KSCrashMonitor_System.m:502:72: note: enclose 'operatingSystemVersion' in an @available check to silence this warning
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:198:27: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:229:30: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSThread.h:74:23: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:40:29: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:44:28: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:64:21: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSDynamicLinker.h:55:20: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSLogger.h:262:24: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:133:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:149:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:198:27: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:229:30: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSThread.h:74:23: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:40:29: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:44:28: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:64:21: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSDynamicLinker.h:55:20: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSLogger.h:262:24: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:133:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-appletvsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:149:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Reporting/Tools/KSReachabilityKSCrash.m:370:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Desktop/KSCrash/Source/KSCrash/Reporting/Tools/KSReachabilityKSCrash.m:377:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:198:27: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSCrashC.h:229:30: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSThread.h:74:23: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:40:29: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:44:28: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSMachineContext.h:64:21: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSDynamicLinker.h:55:20: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Recording, KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSLogger.h:262:24: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:133:60: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [KSCrashAblyFork/Reporting, KSCrashAblyFork/Reporting/Tools, KSCrashAblyFork/Reporting/Sinks, and more...] xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-eetzhbqgtldrrneakwhizkjdyass/Build/Products/Release-watchsimulator/KSCrashAblyFork/KSCrashAblyFork.framework/Headers/KSReachabilityKSCrash.h:149:29: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - ERROR | [iOS] [KSCrashAblyFork/Reporting/Filters/Alert] unknown: Encountered an unknown error (pathname contains null byte) during validation.

@funkyboy
Copy link
Contributor Author

funkyboy commented Feb 7, 2018 •
edited
Loading

The alternative approach I am following is addressing compiler warnings in this fork, without merging upstream changes.

@funkyboy
Copy link
Contributor Author

funkyboy commented Feb 7, 2018

Same kind of errors (but fever) happen if I lint the upstream master

 -> KSCrash (1.15.16)
    - ERROR | [KSCrash/Recording, KSCrash/Reporting, KSCrash/Reporting/Filters, and more...] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - ERROR | [KSCrash/Recording, KSCrash/Reporting, KSCrash/Reporting/Filters, and more...] xcodebuild:  /Users/cesare/Desktop/aaa/KSCrash-master/Source/KSCrash/Recording/Monitors/KSCrashMonitor_Signal.c:202:5: error: use of undeclared identifier 'g_signalStack'

@funkyboy
Copy link
Contributor Author

funkyboy commented Feb 7, 2018

Update: waiting on Toni to allow me access to push new version of the Cocoapod for https://github.com/ably-forks/KSCrash

@funkyboy funkyboy mentioned this issue Feb 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@funkyboy