Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTP11d (Presence.get when SUSPENDED) not implemented; throws on DISCONNECTED #630

Closed
tcard opened this issue Aug 23, 2017 · 0 comments
Closed

RTP11d (Presence.get when SUSPENDED) not implemented; throws on DISCONNECTED #630

tcard opened this issue Aug 23, 2017 · 0 comments
Assignees
@tcard

Comments

@tcard
Copy link
Contributor

tcard commented Aug 23, 2017

(RTP11d) If the Channel is in the SUSPENDED state then the get function will by default, or if waitForSync is set to true, result in an error with code 91005 and a message stating that the presence state is out of sync due to the channel being in a SUSPENDED state. If however the get function is called with waitForSync set to false, then it immediately returns the members currently stored in the PresenceMap giving developers access to the members that were present at the time the channel became SUSPENDED

Plus, on connection DISCONNECTED, we throw, while we should follow RTP16b (although that talks about presence messages, so we probably should clarify what happens with get).
@tcard tcard self-assigned this Aug 23, 2017
@tcard tcard changed the title RTP11d (Presence.get when channel is SUSPENDED) not implemented RTP11d (Presence.get when SUSPENDED) not implemented; throws on DISCONNECTED Sep 13, 2017
@tcard tcard mentioned this issue Sep 13, 2017
Closed
tcard added a commit that referenced this issue Sep 14, 2017
@tcard
Implement RTP11d.
b65c0de 
Fixes #630.
@tcard tcard mentioned this issue Sep 14, 2017
Merged
tcard added a commit that referenced this issue Sep 15, 2017
@tcard
Implement RTP11d. (#636)
16cc357 
Fixes #630.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcard tcard

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tcard