Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from customer re private methods #554

Closed
SimonWoolf opened this issue Dec 6, 2016 · 6 comments
Closed

Feedback from customer re private methods #554

SimonWoolf opened this issue Dec 6, 2016 · 6 comments
Labels
enhancement New feature or improved functionality.

Comments

@SimonWoolf
Copy link
Member

Feedback from a customer that: "there are lots of undocumented functions (which ones can I safely use? Nothing is private.". Matt mentioned they need to send messages to each other; customer replied that that "has been solved with Objective-C using private headers, and it has been solved in Swift with "internal" and "fileprivate" attribute on functions/classes."

@SimonWoolf SimonWoolf added the enhancement New feature or improved functionality. label Dec 6, 2016
@tcard
Copy link
Contributor

tcard commented Dec 6, 2016

We do keep separate public and private headers. I'm not sure how the customer get access to the private headers. From a fresh Xcode project and installing Ably normally I can only see the public API.

@ricardopereira
Copy link
Contributor

Yes, we keep it separated but maybe the customer is adding the lib manually. @SimonWoolf Can you confirm that is the case?

@ricardopereira
Copy link
Contributor

ricardopereira commented Dec 7, 2016

screen shot 2016-12-07 at 13 56 10

Using lib with CocoaPods
Showing only what's public.

@danielrhodes
Copy link

screen shot 2016-12-08 at 13 31 55

screen shot 2016-12-08 at 13 35 48

I'm not sure if any of these are supposed to be private, but some of them don't seem to be listed on your documentation.

@tcard
Copy link
Contributor

tcard commented Dec 9, 2016

@danielrhodes Thanks. All of those are correctly public. ARTRealtimeChannel is described here (make sure you select Swift at the top-right) and ARTRealtimeChannels isn't really in the documentation proper but it is in our thorough API spec that all our client libraries implement.

We really could do a better job mapping in-library documentation to the docs, though! So thanks for bringing this into our attention. We'll definitely work to improve this.

@tcard
Copy link
Contributor

tcard commented Dec 9, 2016

Closing as we're tracking this issue specifically somewhere else now.

@tcard tcard closed this as completed Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

4 participants