Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PagiantedResult isLast and hasNext are methods, not attributes #534

Closed
mattheworiordan opened this issue Nov 16, 2016 · 2 comments
Closed

PagiantedResult isLast and hasNext are methods, not attributes #534

mattheworiordan opened this issue Nov 16, 2016 · 2 comments
Labels
enhancement New feature or improved functionality.

Comments

@mattheworiordan
Copy link
Member

See ably/docs#185

We should bundle this breaking change into 0.9
@mattheworiordan mattheworiordan added the enhancement New feature or improved functionality. label Nov 16, 2016
@tcard
Copy link
Contributor

tcard commented Nov 3, 2017

Sadly the train has left on this one.

Personally I don't think this is bad enough to grant a breaking change, even on a major release. I've mentioned before that the spec should allow fields to be implemented as 0-ary methods and vice versa, in accordance to the Uniform Access Principle.

@tcard tcard closed this as completed Nov 3, 2017
@mattheworiordan
Copy link
Member Author

Sadly the train has left on this one.

Agreed. 🚂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @tcard