Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token Request 'ttl' should be in milliseconds #529

Closed
aquigriffin opened this issue Nov 11, 2016 · 1 comment
Closed

Token Request 'ttl' should be in milliseconds #529

aquigriffin opened this issue Nov 11, 2016 · 1 comment

Comments

@aquigriffin
Copy link

Please represent 'ttl' property of ARTTokenRequest in milliseconds to maintain consistency with other client libraries. For instance, our servers use the Ably-Java lib 0.8.5, to return a token request during the authCallback in the iOS client. The java lib respects the 'ttl' as milliseconds, but the iOS client uses seconds.
@mattheworiordan
Copy link
Member

@aquigriffin we have this one scheduled to be fixed along with adding some new functionality to make the handling of TokenRequest or TokenDetails serialised JSON objects easier, see ably/docs#193.

tcard added a commit that referenced this issue Nov 14, 2016
@tcard
TE6, TD7: Token{Request, Details}::fromJSON
c6713bb 
Implements ably/docs#193.

Fixes #529.
@tcard tcard mentioned this issue Nov 14, 2016
Merged
tcard added a commit that referenced this issue Nov 22, 2016
@tcard
TE6, TD7: Token{Request, Details}::fromJson (#533)
be1712a 
* TE6, TD7: Token{Request, Details}::fromJSON

Implements ably/docs#193.

Fixes #529.

* Rename Token{Request, Details}::fromJSON to Token{Request, Details}::fromJson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @aquigriffin