Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority: Test suite passing #103

Closed
2 tasks done
mattheworiordan opened this issue Dec 2, 2015 · 5 comments
Closed
2 tasks done

Priority: Test suite passing #103

mattheworiordan opened this issue Dec 2, 2015 · 5 comments
Assignees
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@mattheworiordan
Copy link
Member

@ricardopereira, every single PR submitted is passing, see https://github.com/ably/ably-ios/pulls

Before doing any more PRs, we need to ensure that:

  • All tests are passing in Travis CI
  • Test output is legible and easy to understand so that when tests fail, we can easily fix the problem
@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Dec 2, 2015
@ricardopereira
Copy link
Contributor

@mattheworiordan You mean is not passing, right?
#85 has some fixes and is an important PR to verify if it is passing... well, but I notice right now that it is not passing. I will look at it.

@mattheworiordan
Copy link
Member Author

Yes meant not passing, we need to have a test base that passes every time before we keep adding more tests

@ricardopereira
Copy link
Contributor

@ricardopereira
Copy link
Contributor

@mattheworiordan It seems like, sometimes in a random test, it stops with an error: Invalid connection: com.apple.coresymbolicationd. I have a folder with that name on my HD: /System/Library/Caches/com.apple.coresymbolicationd Something related with cache.

@mattheworiordan
Copy link
Member Author

It seems like, sometimes in a random test, it stops with an error: Invalid connection: com.apple.coresymbolicationd. I have a folder with that name on my HD: /System/Library/Caches/com.apple.coresymbolicationd Something related with cache

Ok, well good luck fixing that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

2 participants